[BUG] Edit detector rules table paging goes to page the first page if… #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]>
… rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan
approved these changes
Dec 29, 2022
lezzago
approved these changes
Dec 29, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
#270) * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled #269 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled #269 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit b6e3058)
amsiglan
pushed a commit
that referenced
this pull request
Dec 30, 2022
#270) (#277) * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled #269 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled #269 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit b6e3058) Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
opensearch-project#270) (opensearch-project#277) * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit b6e3058) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
opensearch-project#270) (opensearch-project#277) * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Edit detector rules table paging goes to page the first page if rules on other pages are toggled opensearch-project#269 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit b6e3058) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bad pagination on detectors edit rules page after toggling rules. Currently, if the user toggles rules on any page rather than the first, the pagination is reset to the first page.
Issues Resolved
Closes #269
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.