Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule details flyout on detector create 4th step #266

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Dec 28, 2022

Description

showing popup in detector create flow (4th step)

Issues Resolved

Closes #260

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@djindjic djindjic requested a review from a team December 28, 2022 07:09
@djindjic
Copy link
Contributor Author

@amsiglan

Screen.Recording.2022-12-28.at.8.11.09.AM.mov

@djindjic
Copy link
Contributor Author

Detector edit - rules edit page

Screen.Recording.2022-12-28.at.7.54.44.PM.mov

@amsiglan amsiglan merged commit 5bf6b2e into opensearch-project:main Dec 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 29, 2022
* rule details flyout on detector create 4th step

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rule details flyout on detector edit page

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 5bf6b2e)
amsiglan pushed a commit that referenced this pull request Dec 29, 2022
* rule details flyout on detector create 4th step

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rule details flyout on detector edit page

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 5bf6b2e)

Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…) (opensearch-project#275)

* rule details flyout on detector create 4th step

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rule details flyout on detector edit page

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 5bf6b2e)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…) (opensearch-project#275)

* rule details flyout on detector create 4th step

Signed-off-by: Aleksandar Djindjic <[email protected]>

* rule details flyout on detector edit page

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 5bf6b2e)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Opening rule details flyout on 4th step of create detector flow and detector edit
3 participants