-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rule form validation on submit #264
[FEATURE] Rule form validation on submit #264
Conversation
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Screen.Recording.2022-12-27.at.9.26.26.AM.mov |
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
ruleEditorFormState={ruleEditorFormState} | ||
setRuleEditorFormState={setRuleEditorFormState} | ||
cancel={() => history.replace(ROUTES.RULES)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memoize () => history.replace(ROUTES.RULES)
using useCallback
and send it to both the Visual and Yaml editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Aleksandar Djindjic <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-264-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4c586a68d843e8f671fd1bf5443aaab954b191ee
# Push it to GitHub
git push --set-upstream origin backport/backport-264-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Aligning rule form validation with rest of plugins
Issues Resolved
Closing #215
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.