Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show surrounding documents when index pattern is available; Finding flyout UI polish #216

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Dec 13, 2022

Signed-off-by: Amardeepsingh Siglani [email protected]

Description

This PR

  • Adds view surrounding documents button which opens the discover plugin in new tab window and shows surrounding documents to the user.
    • Currently it works only if the index pattern for the related index to the finding is already present with time field set. Support for creation of index-pattern will be added in follow up PR

image

  • Dedupes document shown as part of multiple rules in Finding flyout and moves it to it's own section.
  • Formats the document as Json document

image

Issues resolved

Partially resolves - #132

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan requested a review from a team December 13, 2022 08:45
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan changed the title Refactored finding flyout to show document separately Show surrounding documents when index pattern is available; Finding flyout UI polish Dec 14, 2022
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit 98c2b5c into opensearch-project:main Dec 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
…lyout UI polish (#216)

* refactored finding flyout

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* show surrounding documents when index-pattern available

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed search filter for log source

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 98c2b5c)
amsiglan added a commit that referenced this pull request Dec 20, 2022
…lyout UI polish (#216) (#245)

* refactored finding flyout

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* show surrounding documents when index-pattern available

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed search filter for log source

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 98c2b5c)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…lyout UI polish (opensearch-project#216) (opensearch-project#245)

* refactored finding flyout

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* show surrounding documents when index-pattern available

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed search filter for log source

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 98c2b5c)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…lyout UI polish (opensearch-project#216) (opensearch-project#245)

* refactored finding flyout

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* show surrounding documents when index-pattern available

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed search filter for log source

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 98c2b5c)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants