Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mac os from unit test platforms #211

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

amsiglan
Copy link
Collaborator

Description

Currently there is no infra setup to be able to successfully run unit tests on mac-os, so it is redundant to even try.
This PR also fixes the below warning shown on commit
image

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan requested a review from a team December 12, 2022 18:27
@amsiglan amsiglan merged commit 34d3a57 into opensearch-project:main Dec 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 14, 2022
* removed mac os from unit test platforms

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed redundant command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 34d3a57)
amsiglan added a commit that referenced this pull request Dec 16, 2022
* removed mac os from unit test platforms

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed redundant command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 34d3a57)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…search-project#223)

* removed mac os from unit test platforms

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed redundant command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 34d3a57)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…search-project#223)

* removed mac os from unit test platforms

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* removed redundant command

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 34d3a57)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants