Updating Preview Message functionality while setting notifications in detector alerts #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishtham-amazon
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 19, 2024
amsiglan
reviewed
Dec 20, 2024
| } from '../../../types'; | ||
| import { getIsNotificationPluginInstalled } from '../../utils/helpers'; | ||
| import Mustache from 'mustache'; |
There was a problem hiding this comment.
Can we use named imports here and other places too?
amsiglan
reviewed
Dec 20, 2024
| @@ -53,6 +58,8 @@ export const NotificationForm: React.FC<NotificationFormProps> = ({ | |||
| const hasNotificationPlugin = getIsNotificationPluginInstalled(); | |||
| const [shouldSendNotification, setShouldSendNotification] = useState(!!action?.destination_id); | |||
| const selectedNotificationChannelOption: NotificationChannelOption[] = []; | |||
| const onDisplayPreviewChange = (e) => setDisplayPreview(e.target.checked); | |||
There was a problem hiding this comment.
memoize this using useCallback?
amsiglan
reviewed
Dec 20, 2024
| onChange={onDisplayPreviewChange} | ||
| /> | ||
| </EuiFlexItem> | ||
| {displayPreview ? ( |
There was a problem hiding this comment.
Nit: We can also do `displayPreview && () instead of the ternary to keep it short
amsiglan
reviewed
Dec 20, 2024
| @@ -537,6 +559,9 @@ export default class AlertConditionPanel extends Component< | |||
|
|
|||
| <NotificationForm | |||
| action={alertCondition.actions[0]} | |||
| context={{ | |||
| ctx: context, | |||
| }} | |||
There was a problem hiding this comment.
This doesn't seem to match the expected type TriggerContext. It doesn't have ctx as the expected field.
amsiglan
reviewed
Dec 20, 2024
amsiglan
approved these changes
Dec 21, 2024
riysaxen-amzn
approved these changes
Dec 21, 2024
no github issue. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-1241-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a72fbc0e3d0c78fcaa152bb9eae8d4b8e83adcac
# Push it to GitHub
git push --set-upstream origin backport-1241-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the message preview feature while setting notifications for detector triggers. The user can click on Preview message check box and view the notification content. The user can also update the message subject and body which will be updated in the notification content.
Current behaviour
Updated Preview
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.