Fix edit trigger for detectors #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on edit Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
riysaxen-amzn
approved these changes
Dec 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit fa0f407) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit fa0f407) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit fa0f407) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit fa0f407) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit fa0f407) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 18, 2024
amsiglan
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s on edit (#1231) (#1234) (cherry picked from commit fa0f407) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jan 10, 2025
…s on edit (#1231) (#1235) (cherry picked from commit fa0f407) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jan 10, 2025
…s on edit (#1231) (#1237) (cherry picked from commit fa0f407) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jan 10, 2025
…s on edit (#1231) (#1236) (cherry picked from commit fa0f407) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jan 10, 2025
…s on edit (#1231) (#1233) (cherry picked from commit fa0f407) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When editing an existing trigger inside a detector, the selected rules as part of the filter don't show up. This happens because the initial state on mount is not populated using detector config. Another issue we see is that all the rules show up as filter options which is not correct since not all of them have been enabled previously
This PR fixes these issues.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.