Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Patch bad detector data for alerts #326

Closed
jovancacvetkovic opened this issue Jan 10, 2023 · 0 comments · Fixed by #328
Closed

[FEATURE] Patch bad detector data for alerts #326

jovancacvetkovic opened this issue Jan 10, 2023 · 0 comments · Fixed by #328
Labels
bug Something isn't working untriaged

Comments

@jovancacvetkovic
Copy link

What is the feature?
A bad detector returns null for detector_id in the alerts response.
Patch the response with data already in UI for that detector.

response alerts.log
@jovancacvetkovic jovancacvetkovic added bug Something isn't working untriaged labels Jan 10, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 10, 2023
@jovancvetkovic3006
[FEATURE] Patch bad detector data for alerts opensearch-project#326
3dbea63 
Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Jan 10, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006
Patch missing detector_id with data already on UI (#328)
5eeb983 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Patch bad detector data for alerts #326

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006 @github-actions
Patch missing detector_id with data already on UI (#328)
723b7a8 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Patch bad detector data for alerts #326

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 5eeb983)
amsiglan pushed a commit that referenced this issue Jan 10, 2023
@opensearch-trigger-bot @jovancvetkovic3006
Patch missing detector_id with data already on UI (#328) (#331)
fcffcaa 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Patch bad detector data for alerts #326

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 5eeb983)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Patch missing detector_id with data already on UI (opensearch-project…
7432a35 
…#328) (opensearch-project#331)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Patch bad detector data for alerts opensearch-project#326

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 5eeb983)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Patch missing detector_id with data already on UI (opensearch-project…
f6a0b8d 
…#328) (opensearch-project#331)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Patch bad detector data for alerts opensearch-project#326

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 5eeb983)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged
Projects
None yet
Milestone
No milestone
1 participant
@jovancacvetkovic