Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add legend for Finding/Alert count in Overview page #291

Closed
kamingleung opened this issue Jan 9, 2023 · 1 comment · Fixed by #318
Closed

[FEATURE] Add legend for Finding/Alert count in Overview page #291

kamingleung opened this issue Jan 9, 2023 · 1 comment · Fixed by #318
Labels
enhancement New feature or request untriaged

Comments

@kamingleung
Copy link

kamingleung commented Jan 9, 2023 •
edited
Loading

Is your feature request related to a problem?
The Findings and alert count chart doesn't have a legend. Users may not be cleared what the blue bar charts or the red trend lines are. Screenshot:
image

What solution would you like?
We should add a legend on the right side of the chart to indicate blue is for Number of findings, red is for Number of active alerts.
Mockup:
image
@kamingleung kamingleung added enhancement New feature or request untriaged labels Jan 9, 2023
@getsaurabh02 getsaurabh02 moved this from Ready to work on to In Progress in Security analytics dashboards 2.5 release Jan 10, 2023
@kamingleung
Copy link
Author

kamingleung commented Jan 10, 2023 •
edited
Loading

@jovancacvetkovic
For Active alerts in this graph, use euiColorDanger
See Colors guideline for details

jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 10, 2023
@jovancvetkovic3006
[FEATURE] Add legend for Finding/Alert count in Overview page opensea…
e43b1ea 
…rch-project#291

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Jan 10, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006
Adds findings alerts legend in overview page (#318)
3538a8b 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add legend for Finding/Alert count in Overview page #291

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 10, 2023
@jovancvetkovic3006 @github-actions
Adds findings alerts legend in overview page (#318)
9ea9800 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add legend for Finding/Alert count in Overview page #291

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 3538a8b)
AWSHurneyt pushed a commit that referenced this issue Jan 10, 2023
@opensearch-trigger-bot @jovancvetkovic3006
Adds findings alerts legend in overview page (#318) (#321)
daccac4 
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add legend for Finding/Alert count in Overview page #291

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 3538a8b)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Adds findings alerts legend in overview page (opensearch-project#318) (…
79381ec 
…opensearch-project#321)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add legend for Finding/Alert count in Overview page opensearch-project#291

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 3538a8b)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Adds findings alerts legend in overview page (opensearch-project#318) (…
cb84774 
…opensearch-project#321)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add legend for Finding/Alert count in Overview page opensearch-project#291

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 3538a8b)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
Security analytics dashboards 2.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds findings alerts legend in overview page jovancacvetkovic/security-analytics-dashboards-plugin
1 participant
@kamingleung