Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add chart tooltips #198

Closed
jovancacvetkovic opened this issue Dec 5, 2022 · 4 comments
Closed

[FEATURE] Add chart tooltips #198

jovancacvetkovic opened this issue Dec 5, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@jovancacvetkovic
Copy link

jovancacvetkovic commented Dec 5, 2022 •
edited
Loading

Is your feature request related to a problem?
Add chart tooltips for a better user experience. Tooltips are already implemented on the Discover page.

Do you have any additional context?
tooltip

As these above are outdated, the next screenshot shows the default vega-lite tooltip
FEATURE Add chart tooltips #198
@jovancacvetkovic jovancacvetkovic added the enhancement New feature or request label Dec 5, 2022
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 14, 2022
@jovancvetkovic3006
[FEATURE] Add chart tooltips opensearch-project#198
8318b4e 
Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Dec 14, 2022
@jovancvetkovic3006
[FEATURE] Add chart tooltips opensearch-project#198
220bff1 
Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Dec 14, 2022
Merged
1 task
@jovancacvetkovic
Copy link
Author

@amsiglan @kamingleung what do you think, is it ok to go with the default tooltip?

amsiglan pushed a commit that referenced this issue Dec 16, 2022
@jovancvetkovic3006
[FEATURE] Add chart tooltips (#225)
091a833 
* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add interactive legend into charts #199

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Dec 16, 2022
@jovancvetkovic3006 @github-actions
[FEATURE] Add chart tooltips (#225)
010f9c6 
* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add interactive legend into charts #199

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 091a833)
amsiglan pushed a commit that referenced this issue Dec 19, 2022
@opensearch-trigger-bot @jovancvetkovic3006
[FEATURE] Add chart tooltips (#225) (#231)
3c7aff9 
* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add chart tooltips #198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add interactive legend into charts #199

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 091a833)

Co-authored-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic
Copy link
Author

Closed with PR #225

@kamingleung
Copy link

kamingleung commented Dec 21, 2022 •
edited
Loading

@jovancacvetkovic Sorry for a late respond, are we using the tooltip component provided by Vega-lite? https://vega.github.io/vega-lite/docs/tooltip.html
Let's style the tooltip to match the ElasticCharts style along showing the color of the trend line the data is on. For graphs with multiple datasets like your screenshots, it should show all of the data set in the same tooltip, see this page for a demo.

Also a screenshot reference on ElasticCharts:
image

@jovancacvetkovic
Copy link
Author

@kamingleung Yes, we are using the default tooltip from Vega-lite, current version of vega-tooltips we are using doesn't support customizing the tooltips. I created an issue #254 to check if we can safely update the vega-tooltips version.

@jovancacvetkovic jovancacvetkovic mentioned this issue Dec 26, 2022
Closed
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
[FEATURE] Add chart tooltips (opensearch-project#225) (opensearch-pro…
a6a118c 
…ject#231)

* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add interactive legend into charts opensearch-project#199

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 091a833)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
[FEATURE] Add chart tooltips (opensearch-project#225) (opensearch-pro…
1336d43 
…ject#231)

* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add interactive legend into charts opensearch-project#199

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 091a833)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamingleung @jovancacvetkovic