-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Adjust styling for Finding details flyout #121
Comments
@kamingleung are we going to add these changes to the flyouts? Also is there a way to have mocks or just use the link in a description? If we change these, should these be applied to rules and alerts too? |
If we are going to do this, that perhaps we should think of some sort of template for the flyouts and use those for all flyouts across the app. |
@jovancacvetkovic What solution would you like?
|
…t#121 Signed-off-by: Jovan Cvetkovic <[email protected]>
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout #121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]>
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout #121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ad62548)
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout #121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ad62548) Co-authored-by: Jovan Cvetkovic <[email protected]>
…pensearch-project#382) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout opensearch-project#121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ad62548) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
…pensearch-project#382) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout opensearch-project#121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ad62548) Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
* [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Adjust styling for Finding details flyout #121 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit ad62548) Co-authored-by: Jovan Cvetkovic <[email protected]>
Is your feature request related to a problem?
This change would improve presentation of information by visually compartmentalizing it in a more clear way.
What solution would you like?
Adjust accordion style: - Add a top border to the first item- Put the accordion content in a grey container, see ISM’s policy detail page for sample: https://playground.opensearch.org/app/opensearch_index_management_dashboards#/policy-details?id=sample_policy
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: