Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adjust styling for Finding details flyout #121

Closed
phestecAMZN opened this issue Nov 16, 2022 · 3 comments · Fixed by #369
Closed

[FEATURE] Adjust styling for Finding details flyout #121

phestecAMZN opened this issue Nov 16, 2022 · 3 comments · Fixed by #369
Labels
enhancement New feature or request

Comments

@phestecAMZN
Copy link
Contributor

Is your feature request related to a problem?
This change would improve presentation of information by visually compartmentalizing it in a more clear way.

What solution would you like?
Adjust accordion style: - Add a top border to the first item- Put the accordion content in a grey container, see ISM’s policy detail page for sample: https://playground.opensearch.org/app/opensearch_index_management_dashboards#/policy-details?id=sample_policy

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@phestecAMZN phestecAMZN added the enhancement New feature or request label Nov 16, 2022
@jovancacvetkovic
Copy link

@kamingleung are we going to add these changes to the flyouts? Also is there a way to have mocks or just use the link in a description? If we change these, should these be applied to rules and alerts too?

@jovancacvetkovic
Copy link

If we are going to do this, that perhaps we should think of some sort of template for the flyouts and use those for all flyouts across the app.

@kamingleung
Copy link

kamingleung commented Jan 13, 2023

@jovancacvetkovic
This applies to the Findings flyout's Rules detail section.
image

What solution would you like?
Adjust the accordion for improving readability:

  1. Add borders for each accordion entry like this:
    image
  2. Add a background and padding to the content inside the accordion like this (example from ISM):
    image

jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 16, 2023
AWSHurneyt pushed a commit that referenced this issue Jan 24, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout #121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 24, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout #121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit ad62548)
amsiglan pushed a commit that referenced this issue Jan 24, 2023
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout #121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit ad62548)

Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
…pensearch-project#382)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout opensearch-project#121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout opensearch-project#369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout opensearch-project#369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit ad62548)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…pensearch-project#382)

* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout opensearch-project#121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout opensearch-project#369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout opensearch-project#369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit ad62548)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this issue Mar 16, 2024
* [FEATURE] Detector must have at least one alert set #288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Adjust styling for Finding details flyout #121

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. #334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout #369

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit ad62548)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants