Migrate recent external PRs from Open Distro #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
approved these changes
Jun 11, 2021
joshuali925
approved these changes
Jun 11, 2021
| @@ -90,7 +90,7 @@ export const DEFAULT_REPORT_HEADER = '<h1>OpenSearch Dashboards Reports</h1>'; | |||
|
|
|||
| export const SECURITY_CONSTANTS = { | |||
| AUTH_COOKIE_NAME: 'security_authentication', | |||
| TENANT_LOCAL_STORAGE_KEY: 'opendistro::security::tenant::show_popup', | |||
| TENANT_LOCAL_STORAGE_KEY: 'opensearch::security::tenant::show_popup', | |||
There was a problem hiding this comment.
the prefix still seems to be opendistro?
https://github.com/opensearch-project/security-dashboards-plugin/blob/main/public/utils/storage-utils.tsx#L18
Also a issue with chrome font rendering was fixed
|
Thanks for merging #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate 2 PRs from OpenDistro and do the renaming.
Issues Resolved
#45
#46
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.