Use commonlyUsedRanges from Kibana Settings instead of a constant value #352

[iget-master]

Description

• Add the uiSettings service from Data plugin as dependency
• Removes unused dependencies (notifications and navigation)
• Change time_range component to use commonlyUsedRanges from uiSettings (following default behavior for EuiSuperDatePicker across entire kibana), allowing user to override defaults
• Removed the constant that was used for commonlyUsedRanges
• Implement tests to check if uiSettings is being called correctly
• Update tests to add missing new prop uiSettings

Issues Resolved

#41

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[iget-master]

Note that although this pull request fixes the Issue #41, this plugin currently breaks the usage of relative dates (date math), so the issue opendistro-for-elasticsearch/kibana-reports#353 (still on the old repository, asked to @zhongnansu move it) must be fixed to this PR make sense.

[iget-master]

Can someone give some attention here to merge this fix out? I'm pretending to fully migrate to opensearch but this is preventing me from doing it.

[zhongnansu]

Note that although this pull request fixes the Issue #41, this plugin currently breaks the usage of relative dates (date math), so the issue opendistro-for-elasticsearch/kibana-reports#353 (still on the old repository, asked to @zhongnansu move it) must be fixed to this PR make sense.

opendistro-for-elasticsearch/kibana-reports#353

@iget-master sorry for not able to follow up in time. The opendistro-for-elasticsearch/kibana-reports#353 has been fixed recently. We can move on with this PR.

@joshuali925 Josh, could you guide him for this PR? Since we recently added uisettings for date_format, does he need to do some extra work to be in consistent with your change? If not, we just ask him to resolve the conflicts and we'll review the PR

[joshuali925]

@iget-master thanks for the PR. We recently added support for dateFormat in uiSettings. There is a module (not a prop since some code will run in discover) to expose the ui settings client https://github.com/opensearch-project/dashboards-reports/blob/93d885c641c8c7fc8beeb081bee6ffd30b44f73b/dashboards-reports/public/components/utils/settings_service.ts#L16-L23

I believe the only change needed is here, and uiSettings can be called this way
https://github.com/opensearch-project/dashboards-reports/blob/93d885c641c8c7fc8beeb081bee6ffd30b44f73b/dashboards-reports/public/components/main/main_utils.tsx#L199

Could you update the PR please? thanks

[zhongnansu]

@iget-master any thoughts?

[iget-master]

I think that's ok. I'm a little busy next days, but asap i can update the pr

[anirudha]

closing an older PR no coverage