Add query shape hash method #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
force-pushed
the
shape-hash
branch
2 times, most recently
from
e4433f7 to
1741799
Compare
deshsidd
reviewed
Aug 6, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
jainankitk
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Add new utility class (SearchSourceBuilderUtils) to supply common search source objects for use in UT/ITs
Refactoring PRs should always be completely separate IMO. Even if the PR seems small, we can break it down further instead of combining unrelated code changes
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
It is not unrelated. I am adding new UTs in this PR so SearchSourceBuilderUtils was not expressly needed until now. |
jainankitk
reviewed
Aug 15, 2024
src/test/java/org/opensearch/plugin/insights/SearchSourceBuilderUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Zane <[email protected]>
deshsidd
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: David Zane <[email protected]> (cherry picked from commit 1f4c4c6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Aug 28, 2024
(cherry picked from commit 1f4c4c6) Signed-off-by: David Zane <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description