Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Identity for OpenSearch blog post #1149
Introducing Identity for OpenSearch blog post #1149
Changes from 6 commits
ffab951
05d4ed1
1892eee
fd41a05
2906d5f
f6d2478
f66dc78
7ba414b
9940282
e69f2a2
1b9fb47
42641fe
d64a4bb
954c7fe
886da5e
01cb9aa
5b1a26e
65ad635
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no Heading 2. I would add one above "Let's look..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rewrite (everything under "Security isolation"):
"Using a minimum number of permissions to run tasks is key to preventing execution errors or software flaws from having an impact on the stability of an OpenSearch cluster. Identity will launch features that can protect all of the separate elements in OpenSearch by isolating the potential impact a problem with one part may exert on another. As a consequence, this will reduce the reach of errors and keep them from affecting other areas of OpenSearch."
Q: Can you check me on the meaning and make sure I haven’t take this off course? I’m admittedly having to use a little imagination here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just looking over something that DC had commented on in another PR regarding the principle of least privilege. Is that the idea here? If yes, I suppose this should be reworded to "Using a minimal set of privileges to allow users to run tasks is key ...". If it's important to emphasize this idea, I could revise this to place a sharper point on the concept and make clear that it's a driver behind this objective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is the case. On the topic of who is creating these permissions, they will be managed internally by the OpenSearch team, so while administrators/users of a cluster will benefit, the only action they need to take is using the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on, that's big ([permissions will be] managed internally by the OpenSearch team, so while administrators/users of a cluster will benefit, the only action they need to take is using the latest version).
Are you adding that? At least, "the only action users need to take is to keep versions up to date.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rewrite (everything under "Get involved"):
"Identity presents a significant departure from the current security model. It does so to provide features that make it easier for OpenSearch developers to access and build assets and for administrators to carry out tasks in a stable environment. Over the last several months we’ve been busy defining new features and building out the tools to prepare for the integration of Security into core OpenSearch. We’ve struck out on this path in an effort to make security features for OpenSearch more efficient, more reliable, and simply easier and more enjoyable to work with.
And since we operate in the open source community, we’d like to learn about your ideas and benefit from your contributions as we make progress and move development along.
Keep an eye out for further blog posts on specific features for Identity, and join us for presentations during the community meetings. Furthermore, you can stay on top of development by visiting the following resources in the OpenSearch repository:
Support for native authentication and authorization in OpenSearch
Feature branch for Identity
Current issues for Identity
We look forward to your participation."
Q: Do you want to provide some instruction for ways to join the community meetings?
Regarding the comment from shanilpa about terminology, what do yo think about adding these for now in a level four heading? I'm not sure what the blog style guide says about this. But I can look into it. For now, this suggestion:
Terms in this blog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I'll add a link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this. It looks like GitHub supports footnotes1, let me know what you think.
Footnotes
https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/ ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is pretty slick!