Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #1354

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 9 comments · Fixed by #1510 or #1580
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #1354

dblock opened this issue Feb 14, 2023 · 9 comments · Fixed by #1510 or #1580

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@pajuric
Copy link

pajuric commented Mar 9, 2023

@dblock @wbeckler - checking status here.

@wbeckler
Copy link
Contributor

The next moves are:

  • a maintainer in the project-website repo adds a CODEOWNERS file with the list of maintainers that is in the MAINTAINERS.md.
  • Adjust the permissions so that those with maintainer access to this repo matches the list

@krisfreedain
Copy link
Member

@dblock @wbeckler - I will work on this

@krisfreedain krisfreedain self-assigned this Mar 23, 2023
@krisfreedain
Copy link
Member

dtaivpp added a commit to dtaivpp/project-website that referenced this issue Apr 6, 2023
@dblock
Copy link
Member Author

dblock commented Apr 13, 2023

Screenshot 2023-04-13 at 11 03 53 AM

Repo permissions are incorrect. Please work with @bbarani's team to adjust.

  • only admin team should be admin
  • individuals from maintainers should each have maintain level access

@dblock dblock reopened this Apr 13, 2023
@dtaivpp dtaivpp removed the untriaged label Apr 20, 2023
@dtaivpp
Copy link
Collaborator

dtaivpp commented Apr 20, 2023

Okay, @dblock I changed the role for that group to 'maintain'. Admins are managed by the global admin group that is still attached.

@dtaivpp dtaivpp closed this as completed Apr 20, 2023
@dblock
Copy link
Member Author

dblock commented Apr 24, 2023

@dtaivpp That's incorrect. Please see the tickets above for what was expected and why we want to delete groups.

You need to have admin = admin, each maintainer individually = maintain, triage = write, delete the project-website group.

@dblock dblock reopened this Apr 24, 2023
@bbarani
Copy link
Member

bbarani commented May 9, 2023

Fixed the permissions. Need to move the CODEOWNERS file to .github/CODEOWNERS.

@dblock
Copy link
Member Author

dblock commented May 10, 2023

Verified, thx.

Screenshot 2023-05-10 at 5 41 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment