add shard level and co-ordinator level task completion count in SBP collector #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
6 tasks
kaushalmahi12
changed the title
Signed-off-by: Kaushal Kumar <[email protected]>
deshsidd
approved these changes
Dec 5, 2023
sgup432
reviewed
Dec 18, 2023
...ain/java/org/opensearch/performanceanalyzer/collectors/SearchBackPressureStatsCollector.java
Show resolved
Hide resolved
sgup432
reviewed
Dec 18, 2023
...ain/java/org/opensearch/performanceanalyzer/collectors/SearchBackPressureStatsCollector.java
Show resolved
Hide resolved
sgup432
approved these changes
Dec 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
============================================
+ Coverage 69.13% 69.40% +0.26%
- Complexity 370 372 +2
============================================
Files 44 44
Lines 2689 2706 +17
Branches 172 172
============================================
+ Hits 1859 1878 +19
+ Misses 726 725 -1
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreReq PRs for this to be approved: opensearch-project/performance-analyzer-commons#53
Github Issue: #587
adding shard level and co-ordinator level completion count in SBP collector which we will consume downstream to calculate SBP RCA health.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.