Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Revert 'Remove jackson-databind and jackson-annotations coming from core' #370

Merged

Conversation

kiranprakash154
Copy link
Contributor

@kiranprakash154 kiranprakash154 commented Jan 11, 2023

Signed-off-by: Kiran Prakash [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Reverting the PR - #349 since Open Search core no longer brings these jackson related libraries.

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kiran Prakash <[email protected]>
@kiranprakash154 kiranprakash154 changed the title update jackson Revert 'Remove jackson-databind and jackson-annotations coming from core' Jan 11, 2023
@kiranprakash154 kiranprakash154 marked this pull request as ready for review January 11, 2023 01:14
@kiranprakash154 kiranprakash154 requested a review from a team January 11, 2023 01:14
@kiranprakash154 kiranprakash154 changed the title Revert 'Remove jackson-databind and jackson-annotations coming from core' [Backport] Revert 'Remove jackson-databind and jackson-annotations coming from core' Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #370 (fea7c46) into 2.x (d40f521) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #370   +/-   ##
=========================================
  Coverage     70.77%   70.77%           
  Complexity      372      372           
=========================================
  Files            44       44           
  Lines          2583     2583           
  Branches        174      174           
=========================================
  Hits           1828     1828           
  Misses          643      643           
  Partials        112      112           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kiranprakash154 kiranprakash154 self-assigned this Jan 11, 2023
@kiranprakash154 kiranprakash154 merged commit 1ffdd47 into opensearch-project:2.x Jan 11, 2023
@kiranprakash154 kiranprakash154 deleted the kp/jackson-update branch January 11, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants