Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set evaluation period from 12 seconds to 5 seconds #410

Merged

Conversation

pranikum
Copy link
Contributor

@pranikum pranikum commented Jun 8, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Currently ThreadMetricsRca exectes in 12 seconds instead of 5 seconds. We will need to pass EVALUATION_INTERVAL_SECONDS in the ThreadMetrcisRca constructor instead of RCA_PERIOD

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #410 (dc1af2e) into main (515b35c) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head dc1af2e differs from pull request most recent head 794d658. Consider uploading reports for the commit 794d658 to get more accurate results

@@             Coverage Diff              @@
##               main     #410      +/-   ##
============================================
- Coverage     76.08%   76.03%   -0.06%     
+ Complexity     2594     2593       -1     
============================================
  Files           302      302              
  Lines         15414    15414              
  Branches       1216     1216              
============================================
- Hits          11728    11720       -8     
- Misses         3191     3198       +7     
- Partials        495      496       +1     
Impacted Files Coverage Δ
...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@khushbr khushbr merged commit e9cc830 into opensearch-project:main Jun 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 9, 2023
Signed-off-by: pranikum <[email protected]>
(cherry picked from commit e9cc830)
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-410-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e9cc83096e57fbb3817ebaa35b18a4d956939f20
# Push it to GitHub
git push --set-upstream origin backport/backport-410-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-410-to-1.3.

khushbr pushed a commit that referenced this pull request Jun 9, 2023
Signed-off-by: pranikum <[email protected]>
(cherry picked from commit e9cc830)

Co-authored-by: pranikum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants