-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "middle-out" order prop option to `OuiPaletteColorBlind' #856
Add new "middle-out" order prop option to `OuiPaletteColorBlind' #856
Conversation
Signed-off-by: Josh Romero <[email protected]>
Would like to get @KrooshalUX opinion on this |
To provide a little more context - there are some legacy vis color utils in OpenSearch Dashboards that try to generate an arbitrary/infinite number of categorical colors. In practice, this generation is not done very well, and very quickly it starts generating very similar colors that are not differentiable: I believe that the long term solution is to focus on differentiability for categorical colors, and to simply repeat/re-use categorical colors rather than using technically distinct ones. But for now, the easiest way to at least use OUI colors as a source of truth was to leverage the |
The more I'm seeing super dark or super light colors on Dashboards, the more I'm thinking I'd like this |
I'll leave this as a possibility, but leaning more toward opensearch-project/OpenSearch-Dashboards#4697 |
I'm taking this out of draft, because I'm still convinced it's useful for visualizations with >10 series. Particularly when stacking bar or area charts, it's common to sort the series so that the series with the largest magnitude come first. In this common scenario, you want the primary vis colors to come first and then start using variants. |
Signed-off-by: Josh Romero <[email protected]>
…joshuarrrr/oui into feat/add-middle-out-color-palette-order
* Add new "middle-out" order prop option to `OuiPaletteColorBlind' Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit c9d0d62) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
… (#1010) * Add new "middle-out" order prop option to `OuiPaletteColorBlind' Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit c9d0d62) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
When dealing with a large number of rotations, you may not always want to start with the darkest variations. This order makes sure the darkest and lightest variants come last.
Issues Resolved
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.