Add leading slash to test in .npmignore #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
BSFishy
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX and
bandinib-amzn
as code owners
seanneumann
approved these changes
Apr 7, 2023
bandinib-amzn
approved these changes
Apr 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit 9a2b1cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit 9a2b1cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit 9a2b1cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy
pushed a commit
that referenced
this pull request
Apr 10, 2023
(cherry picked from commit 9a2b1cd) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit 9a2b1cd) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit 9a2b1cd) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add leading slash to test in .npmignore. This is important, as without it, directories such as
test-env/test/are ignored. Those directories are important as they are used downstream.We could look into other cases where a leading slash could be useful, however that is outside of the scope of this PR. We need this merged ASAP, as it is blocking 1.1 release.
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.