Add build steps to workflow #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
joshuarrrr
reviewed
Apr 6, 2023
Signed-off-by: Matt Provost <[email protected]>
BSFishy
commented
Apr 6, 2023
.github/workflows/build_and_test.yml
Outdated
Comment on lines
72
to
79
| src: | ||
| - 'src/**' | ||
| - package.json | ||
| - yarn.lock | ||
| docs: | ||
| - 'src-docs/**' | ||
| - package.json | ||
| - yarn.lock |
There was a problem hiding this comment.
To reviewers: should other related build files be added here? Ex. postcss.config.js, tsconfig.json, ...
There was a problem hiding this comment.
yeah, I think adding those is a good idea. It's hard to know whether an allowlist or a denylist is easier in this case.
joshuarrrr
approved these changes
Apr 11, 2023
|
Converting to draft to rethink some of the filtering stuff and also get build working on Windows |
Signed-off-by: Matt Provost <[email protected]>
|
I removed the path filter. I think at this point, adding a path filter would require more thought and effort than it's worth. I'd just like to get this out, and we can make a follow-up issue to figure out path filters. |
BSFishy
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
bandinib-amzn and
ashwin-pc
as code owners
AMoo-Miki
approved these changes
Jun 20, 2023
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
BSFishy
commented
Aug 7, 2023
| @@ -39,3 +39,29 @@ jobs: | |||
|
|
|||
| - name: Run unit tests | |||
| run: yarn test-unit | |||
|
|
|||
| build: | |||
| runs-on: ubuntu-latest | |||
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
joshuarrrr
approved these changes
Aug 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Add build steps to workflow Signed-off-by: Matt Provost <[email protected]> * Add path filter Signed-off-by: Matt Provost <[email protected]> * Remove path filter Signed-off-by: Matt Provost <[email protected]> * Update yarn version for build CI Signed-off-by: Matt Provost <[email protected]> * Remove Windows from build CI Signed-off-by: Matt Provost <[email protected]> * Revert yarn version and add changlog entry Signed-off-by: Matt Provost <[email protected]> * Remove workflow matrix Signed-off-by: Matt Provost <[email protected]> * Add artifact upload steps Signed-off-by: Matt Provost <[email protected]> * Set workflow to upload artifacts as package Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 62d5c8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BSFishy
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Add build steps to workflow Signed-off-by: Matt Provost <[email protected]> * Add path filter Signed-off-by: Matt Provost <[email protected]> * Remove path filter Signed-off-by: Matt Provost <[email protected]> * Update yarn version for build CI Signed-off-by: Matt Provost <[email protected]> * Remove Windows from build CI Signed-off-by: Matt Provost <[email protected]> * Revert yarn version and add changlog entry Signed-off-by: Matt Provost <[email protected]> * Remove workflow matrix Signed-off-by: Matt Provost <[email protected]> * Add artifact upload steps Signed-off-by: Matt Provost <[email protected]> * Set workflow to upload artifacts as package Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 62d5c8c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds workflow steps to run
yarn buildandyarn build-docs. These are good as verification steps and also generateoui.d.ts, which will be very useful for #648. They are scheduled to run after bothyarn test-unitandyarn lintrun because they are pretty hefty commands and should only be run if absolutely necessary.Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.