Fix accessibility in doc site #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
joshuarrrr
approved these changes
Mar 30, 2023
BSFishy
commented
Mar 30, 2023
| @@ -127,7 +127,7 @@ const tpl = ` | |||
| </style> | |||
| <a id="root" role="button" aria-labelledby="selected" aria-controls="dropdown" tabindex="0"> | |||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" role="img" | |||
| width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24"> | |||
| width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24" aria-hidden="true"> | |||
There was a problem hiding this comment.
Context for reviewers: OuiIcon already adds the aria-hidden attribute given certain criteria. This icon would meet that criteria. Not sure why this wasn't there in the first place
ashwin-pc
approved these changes
Apr 12, 2023
bandinib-amzn
approved these changes
Apr 12, 2023
rednaksi91
requested review from
seanneumann,
AMoo-Miki,
rednaksi91 and
KrooshalUX
as code owners
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Iskander Rakhmanberdiyev <[email protected]> (cherry picked from commit 18cc9df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 18cc9df) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Iskander Rakhmanberdiyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few places around the doc site where accessibility wasn't passing. This PR fixes that. This doesn't go into any sort of component iteration or refactoring components so these don't need to be specified, only fixing parts that are failing. Although, these might be a good place to start when refactoring components to be more accessible out of the box
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.