Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct super date picker functionality #627

Merged

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Mar 23, 2023

Description

The super date picker is taking two clicks to open, now it is corrected to function as expected.

Screen.Recording.2023-03-23.at.2.28.29.PM.mov

Issues Resolved

Fixes #271

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review March 23, 2023 18:50
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner March 23, 2023 18:50
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BSFishy
Copy link
Contributor

BSFishy commented Apr 6, 2023

As of now, we're not considering changes in UX breaking, so ping me if this needs to be reversed on any of the backports

Update: visual UX changes aren't breaking, but functional ones are.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit bae5a11)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit bae5a11)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit bae5a11)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 12, 2023
(cherry picked from commit bae5a11)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr pushed a commit that referenced this pull request Apr 12, 2023
(cherry picked from commit bae5a11)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr pushed a commit that referenced this pull request Apr 12, 2023
(cherry picked from commit bae5a11)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
BSFishy added a commit to BSFishy/oui that referenced this pull request Apr 18, 2023
BSFishy added a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for Super date field to open picker in one click
3 participants