-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct super date picker functionality #627
Merged
seanneumann
merged 2 commits into
opensearch-project:main
from
AbhishekReddy1127:OUI-SuperdatePicker
Mar 27, 2023
Merged
Correct super date picker functionality #627
seanneumann
merged 2 commits into
opensearch-project:main
from
AbhishekReddy1127:OUI-SuperdatePicker
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AbhishekReddy1127 <[email protected]>
BSFishy
approved these changes
Mar 27, 2023
seanneumann
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As of now, we're not considering changes in UX breaking, so ping me if this needs to be reversed on any of the backports Update: visual UX changes aren't breaking, but functional ones are. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit bae5a11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit bae5a11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit bae5a11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit bae5a11) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit bae5a11) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit bae5a11) Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Neumann <[email protected]>
BSFishy
added a commit
to BSFishy/oui
that referenced
this pull request
Apr 18, 2023
…) (opensearch-project#682)" Signed-off-by: Matt Provost <[email protected]>
BSFishy
added a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Matt Provost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The super date picker is taking two clicks to open, now it is corrected to function as expected.
Screen.Recording.2023-03-23.at.2.28.29.PM.mov
Issues Resolved
Fixes #271
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.