Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Fix yo-doc and yo-component crashes #599

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

andreymyssak
Copy link
Collaborator

Description

  1. yo-doc and yo-component scripts work
  2. After removing node_modules there are no errors regarding trim-newlines
yarn install v1.22.19
[1/4] 🔍  Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
[2/4] 🚚  Fetching packages...
warning Pattern ["gonzales-pe-sl@github:srowhani/gonzales-pe#dev"] is trying to unpack in the same destination "/Users/andreymyssak/Library/Caches/Yarn/v6/npm-gonzales-pe-sl-4.2.3/node_modules/gonzales-pe-sl" as pattern ["gonzales-pe-sl@^4.2.3"]. This could result in non-deterministic behavior, skipping.
[3/4] 🔗  Linking dependencies...
warning " > @elastic/[email protected]" has incorrect peer dependency "babel-eslint@^8.0.0".
warning " > @elastic/[email protected]" has incorrect peer dependency "eslint@^4.1.0".
warning " > @elastic/[email protected]" has incorrect peer dependency "eslint-plugin-babel@^4.1.1".
warning " > @elastic/[email protected]" has incorrect peer dependency "eslint-plugin-jest@^21.0.0".
warning " > @elastic/[email protected]" has incorrect peer dependency "eslint-plugin-mocha@^4.9.0".
warning "react-view > @miksu/prettier > [email protected]" has unmet peer dependency "@angular/compiler@^6.0.0 || ^7.0.0".
warning "react-view > @miksu/prettier > [email protected]" has incorrect peer dependency "remark-parse@^3.0.0 || ^4.0.0 || ^5.0.0".
warning "react-view > @miksu/prettier > [email protected]" has unmet peer dependency "yaml@^1.0.2".
warning " > [email protected]" has incorrect peer dependency "node-sass@^3.8.0 || 4".
warning " > [email protected]" has incorrect peer dependency "node-sass@^4.11.0".
warning "yo > [email protected]" has unmet peer dependency "mem-fs@^1.2.0 || ^2.0.0".
[4/4] 🔨  Building fresh packages...
$ node ./scripts/postinstall.js
✨  Done in 28.16s.

Issues Resolved

#598

Affected Issues

#594
#595

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andreymyssak andreymyssak requested a review from a team as a code owner March 16, 2023 17:22
@ashwin-pc ashwin-pc added the CCI College Contributor Initiative label Mar 16, 2023
@ashwin-pc
Copy link
Member

@andreymyssak Thanks for the PR. It looks like **/meow/trim-newlines was used to mitigate a security vulnerability. See the Mend security check for more details.

@andreymyssak andreymyssak force-pushed the 598-fix-yo branch 2 times, most recently from 08c51b2 to 0187a39 Compare March 17, 2023 01:57
@andreymyssak andreymyssak changed the title [CCI] Update "Yo" and remove "**/meow/trim-newlines" [CCI] Fix yo-doc and yo-component crashes Mar 17, 2023
@andreymyssak
Copy link
Collaborator Author

@ashwin-pc Thanks for pointing this out to me, the code is ready for review

Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andreymyssak andreymyssak mentioned this pull request Mar 20, 2023
6 tasks
@ashwin-pc ashwin-pc merged commit af9324a into opensearch-project:main Mar 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Andrey Myssak <[email protected]>
(cherry picked from commit af9324a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Andrey Myssak <[email protected]>
(cherry picked from commit af9324a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Mar 23, 2023
(cherry picked from commit af9324a)

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr added a commit that referenced this pull request Mar 27, 2023
(cherry picked from commit af9324a)

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.0 CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants