Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Create OuiLoadingDashboards component #597

Conversation

SergeyMyssak
Copy link
Collaborator

@SergeyMyssak SergeyMyssak commented Mar 16, 2023

Description

Added OuiLoadingDashboards component. This component is intended to replace the deprecated OuiLoadingElastic component.

Screenshot 2023-03-16 at 20 22 52

Issues Resolved

#265
#267

Related Issues

#266

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SergeyMyssak SergeyMyssak requested a review from a team as a code owner March 16, 2023 14:28
@ashwin-pc ashwin-pc added the CCI College Contributor Initiative label Mar 16, 2023
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! you made quick work of this issue. This PR looks good to me and I can approve it once the license headers are updated to the latest ones.

src/components/loading/loading_dashboards.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_dashboards.test.tsx Outdated Show resolved Hide resolved
src/components/loading/_loading_dashboards.scss Outdated Show resolved Hide resolved
src-docs/src/views/loading/loading_dashboards.tsx Outdated Show resolved Hide resolved
@SergeyMyssak SergeyMyssak force-pushed the 265-Create-OuiLoadingDashboards-component branch from 001a1ee to f338b90 Compare March 18, 2023 05:39
@SergeyMyssak
Copy link
Collaborator Author

Nice! you made quick work of this issue. This PR looks good to me and I can approve it once the license headers are updated to the latest ones.

Thanks for the comment, it's done!

ashwin-pc
ashwin-pc previously approved these changes Mar 20, 2023
Co-authored-by: Andrey Myssak <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
@SergeyMyssak SergeyMyssak force-pushed the 265-Create-OuiLoadingDashboards-component branch from f338b90 to 9f59fd7 Compare March 22, 2023 09:30
@BSFishy BSFishy merged commit 4e91737 into opensearch-project:main Mar 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 4e91737)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr added a commit that referenced this pull request Mar 27, 2023
(cherry picked from commit 4e91737)

Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants