Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate webpack to the latest #587

Closed
wants to merge 11 commits into from
Closed

Migrate webpack to the latest #587

wants to merge 11 commits into from

Conversation

AbhishekReddy1127
Copy link
Contributor

Description

Migrating Webpack to the latest.

Issues Resolved

Fixes #584

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

AbhishekReddy1127 and others added 7 commits March 10, 2023 05:53
@AbhishekReddy1127
Update webpack cli to latest
75f2bde 
Signed-off-by: AbhishekReddy1127 <[email protected]>
@AbhishekReddy1127
Update the webpack plugins and loaders
2b47c3e 
Signed-off-by: AbhishekReddy1127 <[email protected]>
@BSFishy
Fix build errors
681cb90 
Signed-off-by: Matt Provost <[email protected]>
@AbhishekReddy1127
Update webpack cli to latest
55a0fe8 
Signed-off-by: AbhishekReddy1127 <[email protected]>
@AbhishekReddy1127
Update the webpack plugins and loaders
ca43665 
Signed-off-by: AbhishekReddy1127 <[email protected]>
@BSFishy @AbhishekReddy1127
Fix build errors
d955f57 
Signed-off-by: Matt Provost <[email protected]>
@AbhishekReddy1127
Change webpack configure options and clean up configuration
751cddd 
Signed-off-by: AbhishekReddy1127 <[email protected]>
@BSFishy
Copy link
Contributor

BSFishy commented Mar 16, 2023

Everything should work as intended except yarn start. Need some Node polyfills and Webpack is having trouble resolving some modules

@andreymyssak andreymyssak mentioned this pull request Mar 20, 2023
Closed
6 tasks
@andreymyssak andreymyssak mentioned this pull request Mar 22, 2023
Open
@BSFishy BSFishy added the help wanted Extra attention is needed label Apr 5, 2023
@BSFishy BSFishy mentioned this pull request Apr 27, 2023
Open
31 tasks
@BSFishy
Copy link
Contributor

BSFishy commented Apr 27, 2023

The current status of this work has been posted in #584

@BSFishy
Copy link
Contributor

BSFishy commented May 18, 2023

Close in favor of #765

@BSFishy BSFishy closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Webpack 5
2 participants
@AbhishekReddy1127 @BSFishy