Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Opensearch Logo linking to non-existent file [CCI] #566

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Readme Opensearch Logo linking to non-existent file [CCI] #566

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0525c58
fix: logo linking to non-existent file
timursaurus Mar 7, 2023
525e4b9
chore: use markdown link with alt text
timursaurus Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
![OpenSearch logo](OpenSearch.svg)
<img src="https://opensearch.org/assets/img/opensearch-logo-themed.svg" height="64px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrooshalUX This should also have an alt attribute right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrooshalUX This should also have an alt attribute right?
It's a markdown link now with the alt attribute

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "OpenSearch Dashboards" as the alt content. Thanks!


# OpenSearch UI Framework

Expand Down