-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Kibana reference in commands #535
Merged
seanneumann
merged 6 commits into
opensearch-project:main
from
abbyhu2000:delete_kibana_in_component_development
Mar 2, 2023
Merged
Delete Kibana reference in commands #535
seanneumann
merged 6 commits into
opensearch-project:main
from
abbyhu2000:delete_kibana_in_component_development
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
force-pushed
the
delete_kibana_in_component_development
branch
from
February 28, 2023 20:27
40d7d0e
to
7c6b2f9
Compare
BSFishy
suggested changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some links in this file that refer to Elastic pages
BSFishy
previously approved these changes
Feb 28, 2023
seanneumann
reviewed
Feb 28, 2023
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
delete_kibana_in_component_development
branch
from
March 1, 2023 18:56
0a4fdc1
to
8881ea6
Compare
seanneumann
reviewed
Mar 1, 2023
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
delete_kibana_in_component_development
branch
from
March 1, 2023 21:17
8881ea6
to
1a1bd49
Compare
BSFishy
approved these changes
Mar 2, 2023
seanneumann
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t!
AMoo-Miki
pushed a commit
to AMoo-Miki/oui
that referenced
this pull request
Jul 2, 2023
* Delete kibana reference in commands Signed-off-by: abbyhu2000 <[email protected]> * Change the tgz naming to opensearch Signed-off-by: abbyhu2000 <[email protected]> * Updated doc site link and github reference Signed-off-by: abbyhu2000 <[email protected]> * Change URL to only include domain Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Sean Neumann <[email protected]>
7 tasks
AMoo-Miki
added a commit
that referenced
this pull request
Jul 15, 2023
* Remove beta badge accent color (#99) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Matt Provost <[email protected]> * OUI combo box refine (#183) * Added a prop clearOnBlur Signed-off-by: AbhishekReddy1127 <[email protected]> * Added example for prop clearOnBlur Signed-off-by: AbhishekReddy1127 <[email protected]> --------- Signed-off-by: AbhishekReddy1127 <[email protected]> * Update Comment List Docs (#252) Signed-off-by: Matt Provost <[email protected]> * Updated the section Collapsable Nav (#330) Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Updated the kibana to opensearch_dashboards (#343) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the section drag and drop (#514) Signed-off-by: AbhishekReddy1127 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Update @svgr/core and @svgr/plugin-svgo (#594) (#649) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Migrate from faker to @faker-js/faker (#594) (#655) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Bump @faker-js/faker to v8 (#594) (#768) Signed-off-by: Andrey Myssak <[email protected]> * change beta to experimental (#383) Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Normalize interlink URL usage (#698) (#720) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * [CCI] Add `useDeprecatedPropWarning` and align with `deprecated` hoc (#762) * Add useDeprecatedPropWarning and align with deprecated hoc (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Add multiple props to useDeprecatedPropWarning and pass getMessage to deprecatedComponentWarning (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Use ExclusiveUnion in interfaces (#761) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> --------- Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Update the default branch (#584) (#798) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * [OuiComboBox] Add docs for icon and revise example for clearOnBlur (#806) Signed-off-by: Miki <[email protected]> * Updated bug issue template (#764) * Update bug issue template Signed-off-by: Sirazh Gabdullin <[email protected]> * Add spacing Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> * Move OuiBottomBar default inline styles to the CSS file (#693) (#694) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * [CCI] Update react-window and react-virtualized-auto-sizer dependencies (#652) * Update react-window (#594) * Update react-virtualized-auto-sizer (#594) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Update dropzone (#594) (#651) Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Updated the section Beta badge (#338) Signed-off-by: AbhishekReddy1127 <[email protected]> * Add props and examples for the combobox (#660) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the links in the section Markdown Format (#365) Signed-off-by: AbhishekReddy1127 <[email protected]> * Update Notification event page (#549) Signed-off-by: manasvinibs <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Updated the content in the section Messages and loading (#350) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the content in the section suggest (#347) Signed-off-by: AbhishekReddy1127 <[email protected]> * Update affiliation of Andrey and Sergey (#794) Signed-off-by: Matt Provost <[email protected]> * [CCI] Update dependencies (#716) * Update dependencies (#594) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> * Bump @axe-core/puppeteer to v4.6.1 and puppeteer to v19.11.1 Signed-off-by: Andrey Myssak <[email protected]> * Bump react-window, tabbable and rimraf patch versions Signed-off-by: Andrey Myssak <[email protected]> * Bump @svgr/core, @svgr/plugin-svgo and @svgr/plugin-jsx to v8 Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> * Replace @elastic/datemath with @opensearch/datemath (#204) * Replace @elastic/datemath with @opensearch/datemath Signed-off-by: Matt Provost <[email protected]> * Clean up Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Bump semver to 7.5.3 (#855) * Bump semver to 7.5.3 Signed-off-by: Matt Provost <[email protected]> * Add resolution to eslint plugin Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Remove Split button from OUI docs (#805) (#812) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Updated the text in the section ErrorBoundary (#366) Signed-off-by: AbhishekReddy1127 <[email protected]> * Docs site changes (#96) * first change Signed-off-by: Kroosh Crusius <[email protected]> * undoing first change Signed-off-by: Kroosh Crusius <[email protected]> * making a sample change to test commit success or failure Signed-off-by: Kroosh Crusius <[email protected]> * undoes sample change for testing Signed-off-by: Kroosh Crusius <[email protected]> * minor changes for tone, deleted references to starter projects as they are not maintained by OSD Signed-off-by: Kroosh Crusius <[email protected]> * Delete OUI.iml Removing as included accidentally. * Delete oui.iml Removing as included accidentally. * Update getting_started.md Updated link to node version manager to avoid redirect --------- Signed-off-by: Kroosh Crusius <[email protected]> * Update getting_started.md to remove elastic reference and other changes (#502) Signed-off-by: manasvinibs <[email protected]> * Removed GitHub column from all the tables (#371) Signed-off-by: AbhishekReddy1127 <[email protected]> * Updated the content and Icons in the section CssUtilityClasses (#368) Signed-off-by: AbhishekReddy1127 <[email protected]> * Delete Kibana reference in commands (#535) * Delete kibana reference in commands Signed-off-by: abbyhu2000 <[email protected]> * Change the tgz naming to opensearch Signed-off-by: abbyhu2000 <[email protected]> * Updated doc site link and github reference Signed-off-by: abbyhu2000 <[email protected]> * Change URL to only include domain Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * fixed invalid link in FAQ.md (#751) Signed-off-by: Aigerim Suleimenova <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Signed-off-by: AbhishekReddy1127 <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: manasvinibs <[email protected]> Signed-off-by: Kroosh Crusius <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Aigerim Suleimenova <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Abhishek Reddy <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Kroosh <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Aigerim Suleimenova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete Kibana reference in wiki/component-development.md. Test the commands to ensure they still work.
Issues Resolved
#34
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.