Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.0] Updated link Validation section #322

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[Backport 1.0] Updated link Validation section #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bedfc35
Updated link Validation section (#270)
AbhishekReddy1127 Feb 20, 2023
947792c
Merge branch '1.0' into backport/backport-270-to-1.0
seanneumann Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src-docs/src/views/link/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ export default () => (
<OuiText>
<p>
Open the{' '}
<OuiLink href="http://www.elastic.co" target="_blank">
Elastic website
<OuiLink href="https://Opensearch.org" target="_blank">
OpenSearch website
</OuiLink>{' '}
in a new tab. Setting <OuiCode>target=&ldquo;_blank&rdquo;</OuiCode> also
defaults to <OuiCode>{'external={true}'}</OuiCode>.
</p>
<p>
This{' '}
<OuiLink href="http://www.elastic.co" external>
<OuiLink href="https://Opensearch.org" external>
link
</OuiLink>{' '}
has the <OuiCode>external</OuiCode> prop set to true.
Expand All @@ -37,7 +37,7 @@ export default () => (
<p>
Here is an example of a{' '}
<OuiLink
href="https://github.com/elastic/eui"
href="https://github.com/opensearch-project/oui"
onClick={(e) => {
e.preventDefault();
}}>
Expand Down
4 changes: 2 additions & 2 deletions src-docs/src/views/link/link_validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import React from 'react';
import { OuiLink } from '../../../../src/components';

const urls = [
'https://elastic.co',
'//elastic.co',
'https://opensearch.org',
'//opensearch.org',
'relative/url/somewhere',
'http://username:[email protected]/',
// eslint-disable-next-line no-script-url
Expand Down