Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text in Section Positions #247

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

AbhishekReddy1127
Copy link
Contributor

Signed-off-by: AbhishekReddy1127 [email protected]

Description

Updated the strings in the Flex section.
Screen Shot 2023-01-23 at 12 21 54 PM
Screen Shot 2023-01-23 at 12 31 04 PM
Screen Shot 2023-01-23 at 12 31 29 PM
Screen Shot 2023-01-23 at 12 32 05 PM

Issues Resolved

#173

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AbhishekReddy1127 <[email protected]>
@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review January 23, 2023 20:35
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner January 23, 2023 20:35
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, follows what the issue requested, but pinging @KrooshalUX for confirmation on capitalization

@KrooshalUX KrooshalUX self-requested a review January 24, 2023 01:21
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Further refinements will be captured in the future @BSFishy - primarily to remove the "I am" style of treatment. I will be able to address awkward capitalization issues then as well. ;)

@BSFishy BSFishy merged commit eaf3aba into opensearch-project:main Jan 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit eaf3aba)
@KrooshalUX KrooshalUX mentioned this pull request Feb 28, 2023
8 tasks
ananzh pushed a commit that referenced this pull request Feb 28, 2023
Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit eaf3aba)

Co-authored-by: Abhishek Reddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants