Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUI Button]Changed the references of elastic.co to opensearch.org and changed To… #219

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Jan 12, 2023

Signed-off-by: AbhishekReddy1127 [email protected]

Description

Changed all the references of elastic to opensearch.org in the button docs and replaced the toggle me to toggle and changed the the example "changing content" when the hollow button labeled "toggle" is clicked, the button copy changes to "Hey there good lookin" and now it is changed from "Hey there good lookin" to "Tada!"
Screen Shot 2023-01-12 at 1 29 17 PM
Screen Shot 2023-01-12 at 1 29 35 PM
Screen Shot 2023-01-12 at 1 28 57 PM

Issues Resolved

#195

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ggle button name and its example text

Signed-off-by: AbhishekReddy1127 <[email protected]>
@BSFishy BSFishy requested a review from KrooshalUX January 12, 2023 22:01
@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review January 12, 2023 22:02
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner January 12, 2023 22:02
@BSFishy BSFishy added the OUIDocs label Feb 1, 2023
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BSFishy BSFishy linked an issue Feb 3, 2023 that may be closed by this pull request
4 tasks
@BSFishy BSFishy merged commit 62f372a into opensearch-project:main Feb 13, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 13, 2023
…ggle button name and its example text (#219)

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit 62f372a)
ananzh added a commit that referenced this pull request Feb 28, 2023
…ggle button name and its example text (#219) (#295)

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit 62f372a)

Co-authored-by: Abhishek Reddy <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Button
3 participants