-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update components to respect new breakpoints #1416
Merged
virajsanghvi
merged 2 commits into
opensearch-project:main
from
virajsanghvi:component-breakpoint-fix
Sep 25, 2024
Merged
fix: Update components to respect new breakpoints #1416
virajsanghvi
merged 2 commits into
opensearch-project:main
from
virajsanghvi:component-breakpoint-fix
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <[email protected]>
virajsanghvi
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc and
joshuarrrr
as code owners
September 24, 2024 17:57
AMoo-Miki
approved these changes
Sep 25, 2024
Signed-off-by: Viraj Sanghvi <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1416-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5484bcc1fd9e6ee5e9b2160196f1ea6808095b3e
# Push it to GitHub
git push --set-upstream origin backport/backport-1416-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1416-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5484bcc1fd9e6ee5e9b2160196f1ea6808095b3e
# Push it to GitHub
git push --set-upstream origin backport/backport-1416-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x Then, create a pull request where the |
virajsanghvi
added a commit
to virajsanghvi/oui
that referenced
this pull request
Sep 26, 2024
…#1416) * fix: Update components to respect new breakpoints Signed-off-by: Viraj Sanghvi <[email protected]> * revert i18ntokens.json Signed-off-by: Viraj Sanghvi <[email protected]> --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 5484bcc)
7 tasks
virajsanghvi
added a commit
to virajsanghvi/oui
that referenced
this pull request
Sep 26, 2024
…#1416) * fix: Update components to respect new breakpoints Signed-off-by: Viraj Sanghvi <[email protected]> * revert i18ntokens.json Signed-off-by: Viraj Sanghvi <[email protected]> --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 5484bcc)
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 26, 2024
* fix: Update components to respect new breakpoints Signed-off-by: Viraj Sanghvi <[email protected]> * revert i18ntokens.json Signed-off-by: Viraj Sanghvi <[email protected]> --------- Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 5484bcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we added new breakpoints, we didn't update components to utilize them, leading to some bugs. This just treats new breakpoints like xl out of an abundance of caution.
Issues Resolved
N/A
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.