Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update components to respect new breakpoints #1416

Merged

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Sep 24, 2024

Description

When we added new breakpoints, we didn't update components to utilize them, leading to some bugs. This just treats new breakpoints like xl out of an abundance of caution.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Viraj Sanghvi <[email protected]>
@virajsanghvi virajsanghvi merged commit 5484bcc into opensearch-project:main Sep 25, 2024
14 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1416-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5484bcc1fd9e6ee5e9b2160196f1ea6808095b3e
# Push it to GitHub
git push --set-upstream origin backport/backport-1416-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1416-to-1.x.

@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1416-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5484bcc1fd9e6ee5e9b2160196f1ea6808095b3e
# Push it to GitHub
git push --set-upstream origin backport/backport-1416-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1416-to-1.x.

virajsanghvi added a commit to virajsanghvi/oui that referenced this pull request Sep 26, 2024
…#1416)

* fix: Update components to respect new breakpoints

Signed-off-by: Viraj Sanghvi <[email protected]>

* revert i18ntokens.json

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
(cherry picked from commit 5484bcc)
virajsanghvi added a commit to virajsanghvi/oui that referenced this pull request Sep 26, 2024
…#1416)

* fix: Update components to respect new breakpoints

Signed-off-by: Viraj Sanghvi <[email protected]>

* revert i18ntokens.json

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
(cherry picked from commit 5484bcc)
AMoo-Miki pushed a commit that referenced this pull request Sep 26, 2024
* fix: Update components to respect new breakpoints

Signed-off-by: Viraj Sanghvi <[email protected]>

* revert i18ntokens.json

Signed-off-by: Viraj Sanghvi <[email protected]>

---------

Signed-off-by: Viraj Sanghvi <[email protected]>
(cherry picked from commit 5484bcc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants