Fix combobox appearance when compressed and in-group #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak,
SergeyMyssak and
virajsanghvi
as code owners
AMoo-Miki
changed the title
AMoo-Miki
force-pushed
the
cb-compressed-in-group
branch
from
61122b4 to
af9a9bc
Compare
| } | ||
|
|
||
| .ouiComboBoxPill--plainText { | ||
| line-height: calc($ouiSizeL - 2px); |
There was a problem hiding this comment.
Why ouiSizeL? What is the 2px based on? borders?
There was a problem hiding this comment.
$ouiSizeL is the original value for the line-height of .ouiComboBoxPill--plainText. However, all in-group elements have a - 2px either by using $ouiFormControlLayoutGroupInputCompressedHeight or when the values are not standard, by directly performing the - 2px. This is because the group wrapper adds a top and bottom border around the entire group.
Also: * Adjust prepend and appends in form layouts Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
cb-compressed-in-group
branch
from
af9a9bc to
a5315f8
Compare
| @@ -76,6 +76,20 @@ | |||
| &.ouiComboBox__inputWrap-isLoading.ouiComboBox__inputWrap-isClearable { | |||
| @include ouiFormControlLayoutPadding(3); /* 2 */ | |||
| } | |||
|
|
|||
| &--inGroup#{&}--compressed { | |||
There was a problem hiding this comment.
didn't realize interpolation worked inside selectors
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
) Also: * Adjust prepend and appends in form layouts Signed-off-by: Miki <[email protected]> (cherry picked from commit ce392b5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 23, 2024
) (#1372) Also: * Adjust prepend and appends in form layouts (cherry picked from commit ce392b5) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix combobox appearance when compressed, with pills, and in group
Also:
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.