-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button icon gap prop #1367
Add button icon gap prop #1367
Conversation
335b41e
to
ee0e7a6
Compare
…on and OuiButtonEmpty Signed-off-by: Miki <[email protected]>
ee0e7a6
to
cd0a4f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good - I'm not sure how much I like giving this much control to consumers but hopefully people stick with defaults.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1367-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7bdea7afd9874e3c1b5ad75e5beb62763dcc7fe7
# Push it to GitHub
git push --set-upstream origin backport/backport-1367-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x Then, create a pull request where the |
…on and OuiButtonEmpty (opensearch-project#1367) Signed-off-by: Miki <[email protected]> (cherry picked from commit 7bdea7a) Signed-off-by: Miki <[email protected]>
…on and OuiButtonEmpty (#1367) (#1368) * Allow controlling the gap between the icon and the content of OuiButton and OuiButtonEmpty (#1367) Signed-off-by: Miki <[email protected]> (cherry picked from commit 7bdea7a) Signed-off-by: Miki <[email protected]> * Bump version for the next release Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]>
Description
Add button icon gap prop
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.