Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button icon gap prop #1367

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Aug 21, 2024

Description

Add button icon gap prop

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki AMoo-Miki force-pushed the add-button-icon-gap branch from ee0e7a6 to cd0a4f3 Compare August 21, 2024 21:47
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - I'm not sure how much I like giving this much control to consumers but hopefully people stick with defaults.

@AMoo-Miki AMoo-Miki merged commit 7bdea7a into opensearch-project:main Aug 21, 2024
10 of 14 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1367-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7bdea7afd9874e3c1b5ad75e5beb62763dcc7fe7
# Push it to GitHub
git push --set-upstream origin backport/backport-1367-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1367-to-1.x.

AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Aug 21, 2024
…on and OuiButtonEmpty (opensearch-project#1367)

Signed-off-by: Miki <[email protected]>

(cherry picked from commit 7bdea7a)
Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit that referenced this pull request Aug 21, 2024
…on and OuiButtonEmpty (#1367) (#1368)

* Allow controlling the gap between the icon and the content of OuiButton and OuiButtonEmpty (#1367)

Signed-off-by: Miki <[email protected]>

(cherry picked from commit 7bdea7a)
Signed-off-by: Miki <[email protected]>

* Bump version for the next release

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants