Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce compressed appearance for OuiSuperDatePicker #1307

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Jul 18, 2024

Normal

Screen Shot 2024-07-18 at 11 04 27

Compressed

Screen Shot 2024-07-18 at 11 04 35

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also:
* Sync changelog
* Add compressed SuperDatePicker internal component

Signed-off-by: Miki <[email protected]>
CHANGELOG.md Show resolved Hide resolved
'compressed'
>;

// @internal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get stripped from output? Or what does this do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its only purpose is to document that this is not part of the public API and for public consumption. It allows us to remove them without calling it a breaking change.

@AMoo-Miki AMoo-Miki merged commit c3c02d5 into opensearch-project:main Jul 18, 2024
20 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1307-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3c02d57349e4e1150abbc26f6cda5620de76957
# Push it to GitHub
git push --set-upstream origin backport/backport-1307-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1307-to-1.x.

AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jul 22, 2024
…oject#1307)

Also:
* Sync changelog
* Add compressed SuperDatePicker internal component

Signed-off-by: Miki <[email protected]>

(cherry picked from commit c3c02d5)
Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jul 22, 2024
…oject#1307)

Also:
* Sync changelog
* Add compressed SuperDatePicker internal component

Signed-off-by: Miki <[email protected]>

(cherry picked from commit c3c02d5)
Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jul 22, 2024
…oject#1307)

Also:
* Sync changelog
* Add compressed SuperDatePicker internal component

Signed-off-by: Miki <[email protected]>

(cherry picked from commit c3c02d5)
Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit that referenced this pull request Jul 22, 2024
Also:
* Sync changelog
* Add compressed SuperDatePicker internal component



(cherry picked from commit c3c02d5)

Signed-off-by: Miki <[email protected]>
AMoo-Miki added a commit that referenced this pull request Aug 2, 2024
Also:
* Sync changelog
* Add compressed SuperDatePicker internal component



(cherry picked from commit c3c02d5)

Signed-off-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants