-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce compressed appearance for OuiSuperDatePicker #1307
Introduce compressed appearance for OuiSuperDatePicker #1307
Conversation
dfe081b
to
ffc9c9d
Compare
Also: * Sync changelog * Add compressed SuperDatePicker internal component Signed-off-by: Miki <[email protected]>
ffc9c9d
to
5cd5e42
Compare
'compressed' | ||
>; | ||
|
||
// @internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get stripped from output? Or what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its only purpose is to document that this is not part of the public API and for public consumption. It allows us to remove them without calling it a breaking change.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/oui/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/oui/backport-1.x
# Create a new branch
git switch --create backport/backport-1307-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3c02d57349e4e1150abbc26f6cda5620de76957
# Push it to GitHub
git push --set-upstream origin backport/backport-1307-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/oui/backport-1.x Then, create a pull request where the |
…oject#1307) Also: * Sync changelog * Add compressed SuperDatePicker internal component Signed-off-by: Miki <[email protected]> (cherry picked from commit c3c02d5) Signed-off-by: Miki <[email protected]>
…oject#1307) Also: * Sync changelog * Add compressed SuperDatePicker internal component Signed-off-by: Miki <[email protected]> (cherry picked from commit c3c02d5) Signed-off-by: Miki <[email protected]>
…oject#1307) Also: * Sync changelog * Add compressed SuperDatePicker internal component Signed-off-by: Miki <[email protected]> (cherry picked from commit c3c02d5) Signed-off-by: Miki <[email protected]>
Also: * Sync changelog * Add compressed SuperDatePicker internal component (cherry picked from commit c3c02d5) Signed-off-by: Miki <[email protected]>
Also: * Sync changelog * Add compressed SuperDatePicker internal component (cherry picked from commit c3c02d5) Signed-off-by: Miki <[email protected]>
Normal
Compressed
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.