Rewrite InitialIcon computation without mutable variables
#1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShatilKhan
requested review from
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: ShatilKhan <[email protected]>
|
@BSFishy |
joshuarrrr
reviewed
Dec 15, 2023
There was a problem hiding this comment.
@ShatilKhan This definitely looks like it's on the right track. You can probably take it further by moving the function outside the current scope, so you can write independent unit tests for it (one of the benefits of refactoring from mutable variables to a pure utility fn).
Comment on lines
625
to
626
| let initialIcon; | ||
| let isLoading = false; |
There was a problem hiding this comment.
These should be removed now, right?
| @@ -625,21 +625,27 @@ export class OuiIcon extends PureComponent<OuiIconProps, State> { | |||
| let initialIcon; | |||
| let isLoading = false; | |||
|
|
|||
| // Category 1: cached oui icons | |||
| // Define helper function | |||
| const getIconAndLoadingStatus = (type: any) => { | |||
There was a problem hiding this comment.
I think we should already have a type for type that's more narrow?
ShatilKhan
changed the title
InitialIcon computation without mutable variables
Signed-off-by: Shahriar Shatil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have tried to use a helper function
getIconAndLoadingStatusto return necessary values without having to mutate any variables.The returned values are then destructured into initialIcon and isLoading, which are used to set the state.Issues Resolved
Fixes #1167
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.