[Backport 1.x] [Enhance] Implement Validation for Icon Input Source & Set Default Icon to Beaker
#1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…on to `Beaker` (#1137) * Revise the logic to handle default icon Signed-off-by: Willie Hung <[email protected]> * Categorize different input icon types Signed-off-by: Willie Hung <[email protected]> * Remove unused code Signed-off-by: Willie Hung <[email protected]> * Update CHANGELOG.md Signed-off-by: Willie Hung <[email protected]> * Use readable parameter name Signed-off-by: Willie Hung <[email protected]> * Handle different input cases and add tests Signed-off-by: Willie Hung <[email protected]> --------- Signed-off-by: Willie Hung <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 0d3b6cc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested a review
from rednaksi91
as a code owner
opensearch-trigger-bot
bot
requested review from
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
joshuarrrr
approved these changes
Dec 12, 2023
ashwin-pc
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0d3b6cc from #1137.