Bump @types/react and csstype
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
seanneumann,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
* These are needed to be kept in sync with OSD's. * Switch `css-loader` to an alternate to match that of OSD's, just in case. Signed-off-by: Miki <[email protected]>
BSFishy
approved these changes
Oct 19, 2023
| @@ -237,7 +237,7 @@ | |||
| "sass-embedded": "^1.66.1", | |||
| "sass-lint": "^1.13.1", | |||
| "sass-lint-auto-fix": "^0.21.2", | |||
| "sass-loader": "npm:@bsfishy/[email protected]support-sass-embedded.3", | |||
| "sass-loader": "npm:@amoo-miki/[email protected]node-sass-9.0.0-libsass-3.6.5-with-sass-embedded.rc1", | |||
There was a problem hiding this comment.
Non-blocking: what does this change?
There was a problem hiding this comment.
I don't think it does anything. I was just syncing deps with OSD's.
AMoo-Miki
force-pushed
the
bump-some-types
branch
from
9d58fa4 to
f3ccf52
Compare
joshuarrrr
approved these changes
Oct 19, 2023
No OSD needs changes too. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
* These are needed to be kept in sync with OSD's. * Switch `css-loader` to an alternate to match that of OSD's, just in case. Signed-off-by: Miki <[email protected]> (cherry picked from commit cf3dba1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 19, 2023
* These are needed to be kept in sync with OSD's. * Switch `css-loader` to an alternate to match that of OSD's, just in case. Signed-off-by: Miki <[email protected]> (cherry picked from commit cf3dba1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
@types/reactandcsstypecss-loaderto an alternate to match that of OSD's, just in case.Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.