-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browserlist #1104
base: main
Are you sure you want to change the base?
Update browserlist #1104
Conversation
de4f661
to
c0485e0
Compare
@BSFishy Done with requested changes! |
Signed-off-by: ShatilKhan <[email protected]>
Signed-off-by: ShatilKhan <[email protected]>
Signed-off-by: ShatilKhan <[email protected]>
a59e5c1
to
2df53da
Compare
@ShatilKhan Can you take a look at resolving the conflicts? |
Working on it @joshuarrrr |
@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time to update it. |
Signed-off-by: Shahriar Shatil <[email protected]>
Updated @joshuarrrr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor cleanup things
Co-authored-by: Matt Provost <[email protected]> Signed-off-by: Shahriar Shatil <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done making the suggested changes
Some of the CI fails, so I don't want to merge yet. The issue is that this example class is anonymous:
But the |
Signed-off-by: Miki <[email protected]>
Description
OUI
browserlist
now macthes OSDproduction browserlist
Issues Resolved
Fixes #1023
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.