Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserlist #1104

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

ShatilKhan
Copy link
Contributor

Description

OUI browserlist now macthes OSD production browserlist

Issues Resolved

Fixes #1023

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CHANGELOG.md Outdated Show resolved Hide resolved
.browserslistrc Outdated Show resolved Hide resolved
@ShatilKhan
Copy link
Contributor Author

@BSFishy Done with requested changes!

Signed-off-by: ShatilKhan <[email protected]>
Signed-off-by: ShatilKhan <[email protected]>
Signed-off-by: ShatilKhan <[email protected]>
@joshuarrrr
Copy link
Member

@ShatilKhan Can you take a look at resolving the conflicts?

@ShatilKhan
Copy link
Contributor Author

@ShatilKhan Can you take a look at resolving the conflicts?

Working on it @joshuarrrr

@BSFishy BSFishy added the OSCI label Nov 2, 2023
@joshuarrrr
Copy link
Member

@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time to update it.

@joshuarrrr joshuarrrr marked this pull request as draft November 7, 2023 22:16
@ShatilKhan
Copy link
Contributor Author

@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time to update it.

Updated @joshuarrrr
I wasn't sure what to change mostly, please check it & let me know

@ShatilKhan ShatilKhan marked this pull request as ready for review December 11, 2023 05:07
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor cleanup things

.browserslistrc Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
ShatilKhan and others added 3 commits December 12, 2023 01:29
Co-authored-by: Matt Provost <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
Signed-off-by: Shahriar Shatil <[email protected]>
Copy link
Contributor Author

@ShatilKhan ShatilKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done making the suggested changes

@BSFishy
Copy link
Contributor

BSFishy commented Dec 12, 2023

Some of the CI fails, so I don't want to merge yet. The issue is that this example class is anonymous:

export default class extends Component<CustomActionsProps, CustomActionsState> {

But the proptypes-from-ts-props Babel plugin doesn't support anonymous classes. I'll make an issue for this

#1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match .browserlist with OpenSearch Dashboards
4 participants