Update dependency jest-cli to v25 #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mend-for-github.aaakk.us.kg[bot]](https://avatars.githubusercontent.com/in/30796?s=60&v=4){kind=small}
mend-for-github.aaakk.us.kg
bot
added
the
security fix
mend-for-github.aaakk.us.kg
bot
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
|
mend raises a pr that its own security audit detects new vulnerabilities... also does this even work? i know @joshuarrrr was working on an update similar to this but from what I remember, didn't get very far.. |
|
@BSFishy I actually have a WIP branch of this working - I'll push as a draft PR today. The biggest blocker is tests that try to explicitly validate focus changes. Due to newer versions of JSDom and still relying on Enzyme, checking the currently focused element seems to not work consistently. We may decide it's worth having some skipped focus test for the time being until we can sufficiently decide #654 |
7 tasks
|
closing in favor of #1102 |
mend-for-github.aaakk.us.kg
bot
deleted the
whitesource-remediate/jest-cli-25.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^24.1.0->^25.0.0By merging this PR, the issue #630 will be automatically resolved and closed:
Release Notes
jestjs/jest
v25.0.0Compare Source