Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCI] Replace Elastic with OpenSearch in the examples #622

Closed
andreymyssak opened this issue Mar 23, 2023 · 2 comments
Closed

[CCI] Replace Elastic with OpenSearch in the examples #622

andreymyssak opened this issue Mar 23, 2023 · 2 comments
Assignees
@andreymyssak
Labels
CCI College Contributor Initiative enhancement New feature or request

Comments

@andreymyssak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

I still see Elastic logos and labels on the website, which can be confusing to users (see pictures below).

Basic Card

Page

Header

Describe the solution you'd like

I propose to replace all Elastic logos and labels that are used in the examples and are visible to users on OpenSearch.
@andreymyssak andreymyssak added the enhancement New feature or request label Mar 23, 2023
andreymyssak added a commit to andreymyssak/oui that referenced this issue Mar 23, 2023
@andreymyssak
Replace Elastic with OpenSearch in the examples (opensearch-project#622)
e0e9697 
Signed-off-by: Andrey Myssak <[email protected]>
@andreymyssak andreymyssak mentioned this issue Mar 23, 2023
Merged
6 tasks
@KrooshalUX
Copy link
Contributor

Thanks for catching these.

A few quick follow ups and questions:

  • I am not seeing the same "card" example you have screenshot - what page / URL did you find that on?
  • In regards to /page, it looks like (OUI Docs) Page #177 was closed before all tasks were completed.
  • In regards to /header - it looks like this is realted to Update header logo defaults #580 and potentially also the blocked PR I had opened. I think @BSFishy was participating in unblocking my PR

@joshuarrrr joshuarrrr added CCI College Contributor Initiative and removed untriaged labels Mar 23, 2023
@KrooshalUX KrooshalUX mentioned this issue Mar 23, 2023
Open
2 tasks
@andreymyssak
Copy link
Collaborator Author

@KrooshalUX

I am not seeing the same "card" example you have screenshot - what page / URL did you find that on?

https://oui.opensearch.org/1.0/#/display/card#basic-card -> click on the playground in the first example

In regards to /header - it looks like this is related to #580 and potentially also the blocked PR I had opened. I think @BSFishy was participating in unblocking my PR

In #580 we changed the default values, but many examples declare icon names explicitly, so the changes in #580 will only resolve part of the issues.

seanneumann pushed a commit that referenced this issue Mar 27, 2023
@andreymyssak
Replace Elastic with OpenSearch in the examples (#622) (#623)
96deccc 
Signed-off-by: Andrey Myssak <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 25, 2023
@github-actions
Replace Elastic with OpenSearch in the examples (#622) (#623)
c797ce3 
Signed-off-by: Andrey Myssak <[email protected]>
(cherry picked from commit 96deccc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 9, 2023
@github-actions
Replace Elastic with OpenSearch in the examples (#622) (#623)
912a2dd 
Signed-off-by: Andrey Myssak <[email protected]>
(cherry picked from commit 96deccc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy pushed a commit that referenced this issue May 9, 2023
@opensearch-trigger-bot @github-actions
Replace Elastic with OpenSearch in the examples (#622) (#623) (#753)
4012be0 
(cherry picked from commit 96deccc)

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SergeyMyssak pushed a commit to SergeyMyssak/oui that referenced this issue May 10, 2023
@andreymyssak @SergeyMyssak
Replace Elastic with OpenSearch in the examples (opensearch-project#622…
df32602 
…) (opensearch-project#623)

Signed-off-by: Andrey Myssak <[email protected]>
ashwin-pc pushed a commit that referenced this issue May 17, 2023
@opensearch-trigger-bot @github-actions
Replace Elastic with OpenSearch in the examples (#622) (#623) (#735)
7cc6638 
(cherry picked from commit 96deccc)

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@seanneumann seanneumann moved this to Done in Look & Feel May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymyssak andreymyssak

Labels
CCI College Contributor Initiative enhancement New feature or request
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuarrrr @andreymyssak @KrooshalUX