Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Open Graph url #557

Closed
BSFishy opened this issue Mar 3, 2023 · 4 comments
Closed

Update Open Graph url #557

BSFishy opened this issue Mar 3, 2023 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Mar 3, 2023

Artifact from when we forked:

<meta property="og:url" content="hhttps://elastic.github.io/eui">

This url should be changed to https://oui.opensearch.org/

@BSFishy BSFishy added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 3, 2023
@andreymyssak
Copy link
Collaborator

I see that https://elastic.github.io/eui is also used in many other places, f.e. wiki/creating-components-manually.md

[docs]: https://elastic.github.io/eui/

What I suggest here is adjusting the current task a bit to change to the right URL everywhere.

andreymyssak added a commit to andreymyssak/oui that referenced this issue Mar 8, 2023
@joshuarrrr
Copy link
Member

@andreymyssak There may be some overlapping effort or work in #560

BSFishy pushed a commit that referenced this issue Mar 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 9, 2023
Signed-off-by: Andrey Myssak <[email protected]>
(cherry picked from commit fb72dc7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seanneumann added a commit that referenced this issue Mar 9, 2023
(cherry picked from commit fb72dc7)

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
@andreymyssak
Copy link
Collaborator

@joshuarrrr, @BSFishy Looks like all the work is done, if it is not, note what else is left

@BSFishy
Copy link
Contributor Author

BSFishy commented Mar 17, 2023

You're right, thanks. Closing this

@BSFishy BSFishy closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants