Skip to content

Commit

Permalink
Made recommended changes to git pre-commit hook (#1072)
Browse files Browse the repository at this point in the history
* made recommended changes to git pre-commit hook

Signed-off-by: vmalaviya <[email protected]>

* updated changelog

Signed-off-by: vmalaviya <[email protected]>

* Apply suggestions from code review

Changed styling in CHANGELOG.md to maintain consistency. Fixed typo in pre-commit hook.

Co-authored-by: Matt Provost <[email protected]>
Signed-off-by: Varun Malaviya <[email protected]>

---------

Signed-off-by: vmalaviya <[email protected]>
Signed-off-by: Varun Malaviya <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
  • Loading branch information
DustyDogCodex and BSFishy authored Oct 16, 2023
1 parent 0d20b45 commit ae0171d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@

### 🛠 Maintenance

- Made changes to `pre-commit` hook to only use `lint` instead of running `test-staged` script ([#1072](https://github.com/opensearch-project/oui/pull/1072))
- [CVE-2023-26136] Add resolution for tough-cookie to ^4.1.3 ([#889](https://github.com/opensearch-project/oui/pull/889))
- [CVE-2023-26115] Bump word-wrap from 1.2.3 to 1.2.4 ([#891](https://github.com/opensearch-project/oui/pull/891))
- Bump Node version to 18.16.0 ([#900](https://github.com/opensearch-project/oui/pull/900))
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"test": "yarn lint && yarn test-unit",
"test-unit": "cross-env NODE_ENV=test jest --config ./scripts/jest/config.json",
"test-a11y": "node ./scripts/a11y-testing",
"test-staged": "yarn lint && node scripts/test-staged.js",
"test-staged": "node scripts/test-staged.js",
"start-test-server": "BABEL_MODULES=false NODE_ENV=puppeteer NODE_OPTIONS=--max-old-space-size=4096 webpack-dev-server --config src-docs/webpack.config.js --port 9999",
"yo-component": "yo ./generator-oui/app/component.js",
"start-test-server-and-a11y-test": "cross-env WAIT_ON_TIMEOUT=600000 start-server-and-test start-test-server http-get://localhost:9999 test-a11y",
Expand Down Expand Up @@ -90,7 +90,7 @@
"yo/meow": "^9.0.0"
},
"pre-commit": [
"test-staged"
"lint"
],
"dependencies": {
"@types/chroma-js": "^2.4.0",
Expand Down

0 comments on commit ae0171d

Please sign in to comment.