Skip to content

Commit

Permalink
Convert shorthand palette colors to full 6-char hex (#1262)
Browse files Browse the repository at this point in the history
Signed-off-by: Miki <[email protected]>
  • Loading branch information
AMoo-Miki authored May 1, 2024
1 parent 068d41d commit 828383c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .sass-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,5 @@ rules:
no-warn: 0
# Transition all is useful in certain situations and there's no recent info to suggest slowdown
no-transition-all: 0

hex-length: 'long'
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- Eliminate screenreader content when copying and pasting data grid table ([#1198](https://github.com/opensearch-project/oui/pull/1198))
- [Next Theme] Set base font size to 18px ([#1221](https://github.com/opensearch-project/oui/pull/1221))
- [Next Theme] Revert `font-weight` of OuiButton to normal from semi-bold ([#1222](https://github.com/opensearch-project/oui/pull/1222))
- Convert shorthand palette colors to full 6-char hex ([#1262](https://github.com/opensearch-project/oui/pull/1262))

### 🐛 Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion src/services/color/oui_palettes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export const ouiPaletteForLightBackground = function (): OuiPalette {
};

export const ouiPaletteForDarkBackground = function (): OuiPalette {
return ['#1BA9F5', '#7DE2D1', '#F990C0', '#F66', '#FFCE7A'];
return ['#1BA9F5', '#7DE2D1', '#F990C0', '#FF6666', '#FFCE7A'];
};

const positiveColor: HEX = '#209280';
Expand Down
2 changes: 1 addition & 1 deletion src/themes/oui-next/oui_next_colors_dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $ouiColorAccent: #F990C0;
// Status
$ouiColorSuccess: $ouiColorSecondary;
$ouiColorWarning: #FFCE7A;
$ouiColorDanger: #F66;
$ouiColorDanger: #FF6666;

// Grays
$ouiColorEmptyShade: #0A121A;
Expand Down
2 changes: 1 addition & 1 deletion src/themes/oui/oui_colors_dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $ouiColorAccent: #F990C0;
// Status
$ouiColorSuccess: $ouiColorSecondary;
$ouiColorWarning: #FFCE7A;
$ouiColorDanger: #F66;
$ouiColorDanger: #FF6666;

// Grays
$ouiColorEmptyShade: #1D1E24;
Expand Down

0 comments on commit 828383c

Please sign in to comment.