-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for serializing Spark's DecimalType #947
Add support for serializing Spark's DecimalType #947
Conversation
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
integ-test/src/integration/scala/org/opensearch/flint/spark/FlintSparkSuite.scala
Outdated
Show resolved
Hide resolved
...tion/scala/org/opensearch/flint/spark/iceberg/FlintSparkIcebergMaterializedViewITSuite.scala
Outdated
Show resolved
Hide resolved
…suite Signed-off-by: Chase Engelbrecht <[email protected]>
Could we backport this change to 0.6? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.6 0.6
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.6
# Create a new branch
git switch --create backport/backport-947-to-0.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0943f1fbe893349688aaa84c1d1fcab69156d264
# Push it to GitHub
git push --set-upstream origin backport/backport-947-to-0.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.6 Then, create a pull request where the |
@engechas could you backport to 0.6 manually? |
* Add support for serializing DecimalType in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Fix checkstyle Signed-off-by: Chase Engelbrecht <[email protected]> * Add documentation on the new serialization behavior Signed-off-by: Chase Engelbrecht <[email protected]> * Fix integ test Signed-off-by: Chase Engelbrecht <[email protected]> * Actually fix integ tests Signed-off-by: Chase Engelbrecht <[email protected]> * Move the decimal and map IT to the base suite instead of the iceberg suite Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]> (cherry picked from commit 0943f1f)
Created #962 to manually backport to 0.6 |
* Add support for serializing DecimalType in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Fix checkstyle Signed-off-by: Chase Engelbrecht <[email protected]> * Add documentation on the new serialization behavior Signed-off-by: Chase Engelbrecht <[email protected]> * Fix integ test Signed-off-by: Chase Engelbrecht <[email protected]> * Actually fix integ tests Signed-off-by: Chase Engelbrecht <[email protected]> * Move the decimal and map IT to the base suite instead of the iceberg suite Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]> (cherry picked from commit 0943f1f)
…) (opensearch-project#962) * Add support for serializing DecimalType in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Fix checkstyle Signed-off-by: Chase Engelbrecht <[email protected]> * Add documentation on the new serialization behavior Signed-off-by: Chase Engelbrecht <[email protected]> * Fix integ test Signed-off-by: Chase Engelbrecht <[email protected]> * Actually fix integ tests Signed-off-by: Chase Engelbrecht <[email protected]> * Move the decimal and map IT to the base suite instead of the iceberg suite Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]> (cherry picked from commit 0943f1f)
* Add support for serializing DecimalType in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Fix checkstyle Signed-off-by: Chase Engelbrecht <[email protected]> * Add documentation on the new serialization behavior Signed-off-by: Chase Engelbrecht <[email protected]> * Fix integ test Signed-off-by: Chase Engelbrecht <[email protected]> * Actually fix integ tests Signed-off-by: Chase Engelbrecht <[email protected]> * Move the decimal and map IT to the base suite instead of the iceberg suite Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]>
Description
Adds support for serializing Spark's DecimalType in FlintDataType
Related Issues
List any issues this PR will resolve, e.g. Resolves [...].
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.