-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support aggregate functions in Eval expressions #757
Conversation
Signed-off-by: Lantao Jin <[email protected]>
@@ -177,27 +267,30 @@ class PPLLogicalPlanEvalTranslatorTestSuite | |||
comparePlans(expectedPlan, logPlan, checkAnalysis = false) | |||
} | |||
|
|||
// Todo fields-excluded command not supported | |||
ignore("test eval expressions with fields-excluded command") { | |||
test("test eval expressions with fields-excluded command") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not related. Just enable the test since fields exclude list has been supported.
comparePlans(expectedPlan, logPlan, checkAnalysis = false) | ||
} | ||
|
||
// Todo fields-included command not supported | ||
ignore("test eval expressions with fields-included command") { | ||
test("test eval expressions with fields-included command") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@LantaoJin this is great !
|
I am going to close this due to #755 (comment) |
Description
Aggregate functions could work in select clause even there is no group by as long as all items in
select
are aggregate functions.Here are some examples:
But the following queries should throw exceptions
They could work with a
group by
Similar, aggregate functions in PPL could work in
eval
command, because an eval expression equals to add a projection to existing project list.Here are some examples:
But the following PPL queries should throw exceptions
Issues Resolved
#755
Check List
- [ ] Updated documentation (ppl-spark-integration/README.md)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.