Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker-compose setting for IT testing #606

Closed
wants to merge 1 commit into from

Conversation

salyh
Copy link
Contributor

@salyh salyh commented Aug 29, 2024

Description

Add Docker-compose setting for IT testing

Issues Resolved

#601

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@salyh
Copy link
Contributor Author

salyh commented Aug 29, 2024

I need still to wire spark and opensearch and add some docs ...

@YANG-DB
Copy link
Member

YANG-DB commented Aug 29, 2024

nice
can you also add opensearch dashbords to the docker compose so that we can acutally test ppl directly from the query workbench ?
thanks ...
see example here

@salyh
Copy link
Contributor Author

salyh commented Aug 29, 2024

Opensearch Dashboards are already there, see https://github.com/opensearch-project/opensearch-spark/pull/606/files#r1736775479

@YANG-DB YANG-DB added the Lang:PPL Pipe Processing Language support label Aug 29, 2024
@@ -0,0 +1,76 @@
---
services:
ppl-opensearch-node:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this generic Docker setup instead of only PPL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats is a good idea

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSearch can only work with EMR Serverless Spark.

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a section in the readme file explaining how to run this and test PPL/SQL queries against this spark service...

@@ -0,0 +1,4 @@
FROM bitnami/spark:3.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started some work on running with the EMR Spark image.

#647 (comment)

If there is interest, I could put up a PR. I would keep what you have here, but add a separate Dockerfile for EMR Spark.

@@ -0,0 +1,76 @@
---
services:
ppl-opensearch-node:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSearch can only work with EMR Serverless Spark.

@salyh
Copy link
Contributor Author

salyh commented Sep 12, 2024

Next steps:

@salyh
Copy link
Contributor Author

salyh commented Oct 7, 2024

@YANG-DB any update?

@YANG-DB
Copy link
Member

YANG-DB commented Dec 6, 2024

closing this as its being addressed here

@YANG-DB YANG-DB closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lang:PPL Pipe Processing Language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants