Publish artifacts to maven local #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
requested changes
Aug 16, 2022
saratvemulapalli
previously approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Take care of good comments by @dbwiddis , otherwise looks good to me.
Care to update our developer guide?
joshpalis
previously approved these changes
Aug 17, 2022
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
dismissed stale reviews from joshpalis and saratvemulapalli
via
04e8eef
Signed-off-by: Owais Kazi <[email protected]>
Pushed the change 🙂 |
dbwiddis
approved these changes
Aug 20, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Publish artifacts to maven local Signed-off-by: Owais Kazi <[email protected]> * PR comments and updated the dev guide Signed-off-by: Owais Kazi <[email protected]> * Renamed project in settings.gradle Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owais Kazi [email protected]
Description
Publish artifacts to Maven and use SDK as a library. This will help us to just import the code from SDK rather than having the whole SDK package in AD extension.
Issues Resolved
Closes #98
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.