Rename to Extensions #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dbwiddis
previously requested changes
Aug 1, 2022
| @@ -97,16 +97,16 @@ public DiscoveryNode getOpensearchNode() { | |||
| * @param pluginRequest The request to handle. | |||
There was a problem hiding this comment.
Why are we still naming the parameter "plugin"?
| @@ -97,16 +97,16 @@ public DiscoveryNode getOpensearchNode() { | |||
| * @param pluginRequest The request to handle. | |||
| * @return A response to OpenSearch validating that this is an extension. | |||
| */ | |||
| PluginResponse handlePluginsRequest(PluginRequest pluginRequest) { | |||
| InitializeExtensionsResponse handlePluginsRequest(InitializeExtensionsRequest pluginRequest) { | |||
There was a problem hiding this comment.
Why is the method still handling "Plugins" request?
| @@ -97,16 +97,16 @@ public DiscoveryNode getOpensearchNode() { | |||
| * @param pluginRequest The request to handle. | |||
| * @return A response to OpenSearch validating that this is an extension. | |||
| */ | |||
| PluginResponse handlePluginsRequest(PluginRequest pluginRequest) { | |||
| InitializeExtensionsResponse handlePluginsRequest(InitializeExtensionsRequest pluginRequest) { | |||
| logger.info("Registering Plugin Request received from OpenSearch"); | |||
There was a problem hiding this comment.
The javadocs and log messages should be renamed consistently.
| @@ -100,8 +100,8 @@ public void testHandlePluginsRequest() throws UnknownHostException { | |||
| emptySet(), | |||
| Version.CURRENT | |||
| ); | |||
| PluginRequest pluginRequest = new PluginRequest(sourceNode, null); | |||
| PluginResponse response = extensionsRunner.handlePluginsRequest(pluginRequest); | |||
| InitializeExtensionsRequest pluginRequest = new InitializeExtensionsRequest(sourceNode, null); | |||
| PluginRequest pluginRequest = new PluginRequest(sourceNode, null); | ||
| PluginResponse response = extensionsRunner.handlePluginsRequest(pluginRequest); | ||
| InitializeExtensionsRequest pluginRequest = new InitializeExtensionsRequest(sourceNode, null); | ||
| InitializeExtensionsResponse response = extensionsRunner.handlePluginsRequest(pluginRequest); |
There was a problem hiding this comment.
Same as Dan suggested.
Rename everything Plugin to Extension.
Suggested change
| InitializeExtensionsResponse response = extensionsRunner.handlePluginsRequest(pluginRequest); | |
| InitializeExtensionsResponse response = extensionsRunner.handleExtensionInitRequest(extensionInitRequest); |
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
owaiskazi19
reviewed
Aug 10, 2022
| @@ -99,17 +99,17 @@ public DiscoveryNode getOpensearchNode() { | |||
| } | |||
|
|
|||
| /** | |||
| * Handles a plugin request from OpenSearch. This is the first request for the transport communication and will initialize the extension and will be a part of OpenSearch bootstrap. | |||
| * Handles a extensions request from OpenSearch. This is the first request for the transport communication and will initialize the extension and will be a part of OpenSearch bootstrap. | |||
owaiskazi19
reviewed
Aug 10, 2022
| opensearchNode = pluginRequest.getSourceNode(); | ||
| InitializeExtensionsResponse handleExtensionInitRequest(InitializeExtensionsRequest extensionInitRequest) { | ||
| logger.info("Registering Extension Request received from OpenSearch"); | ||
| InitializeExtensionsResponse initializeExtensionsResponse = new InitializeExtensionsResponse("RealExtension"); |
There was a problem hiding this comment.
new InitializeExtensionsResponse("RealExtension") -> new InitializeExtensionsResponse(extensionSettings.getExtensionName())
Signed-off-by: mloufra <[email protected]>
owaiskazi19
approved these changes
Aug 10, 2022
saratvemulapalli
approved these changes
Aug 10, 2022
|
Looks like @dbwiddis requested changes, so we cannot merge this in without Dan's approval. |
|
As build will fail for the other PRs. Dismissing @dbwiddis changes and merging this PR. |
owaiskazi19
dismissed
dbwiddis’s stale review
As build will fail for the other PRs
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* issue opensearch-project#28 Signed-off-by: mloufra <[email protected]> * issue opensearch-project#28 Signed-off-by: mloufra <[email protected]> * Rename to javadoc, log message and method to extensions Signed-off-by: mloufra <[email protected]> * Rename the remaining to extensions Signed-off-by: mloufra <[email protected]> * fix bug on ExtensionsRunner.java Signed-off-by: mloufra <[email protected]> Signed-off-by: mloufra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra [email protected]
Description
Change the class (PluginRequest, PluginResponse) to (InitializeExtensionsRequest, InitializeExtensionsResponse), and the variable name related to class (PluginRequest, PluginResponse).
Equivalent PR on OpenSearch : opensearch-project/OpenSearch#4063
Issues Resolved
#28
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.